moj-analytical-services / pydbtools

Python version of dbtools
https://moj-analytical-services.github.io/pydbtools/
10 stars 2 forks source link

Make s3_output explicit #130

Closed gwionap closed 1 month ago

gwionap commented 2 months ago
gwionap commented 1 month ago

@Thomas-Hirsch - above is needed so that _create_temp_database uses the same s3 output location as used elsewhere and for it not to default to the workgroup's location.

Also, I think an additional environment variable is needed for grabbing the default region when used with dbtools and where AWS_DEFAULT_REGION and AWS_REGION are fixed by your environment / outside your control. I've used APP_AWS_REGION for now, but open to suggestions for a better name.

gwionap commented 1 month ago

@Thomas-Hirsch - changes made and tested ready for final review.