moj-analytical-services / pydbtools

Python version of dbtools
https://moj-analytical-services.github.io/pydbtools/
11 stars 2 forks source link

Pin s3fs to lower version #30

Closed MrAlecJohnson closed 4 years ago

MrAlecJohnson commented 4 years ago

Lots of people are getting dependency conflicts when installing pydbtools. This is because s3fs >= 0.5.0 adds aiobotocore, which is very picky about the version of botocore it works with.

This pull request pins s3fs below 0.5.0 to resolve these version conflicts. It also adds a standard gitignore.

There's an alternative to pinning s3fs: pinning botocore to 1.17.44. This would let us use more recent s3fs versions. However, I've pinned s3fs instead because:

If this becomes a problem in the future, we could remove s3fs from pydbtools and use boto3 instead. This might be easier than navigating the version conflicts - but it seemed excessive to go for this change straight away.