Fetch list of accessible buckets via role policy

moj-analytical-services / s3tools

Interact with files in s3 on the Analytical Platform

8 stars 2 forks source link

Fetch list of accessible buckets via role policy #23

Closed andyhd closed 6 years ago

andyhd commented 6 years ago

Reimplemented accessible_buckets to fetch the s3-access role policy for the current user, which lists the S3 buckets the user has read-write or read-only access to.
This takes only 1 request to the AWS IAM API, instead of 1 request to S3 to fetch all buckets and then 1 request per bucket to determine access.
This also provides a simple (incomplete) wrapper around making requests to AWS APIs, instead of using CloudyR libraries, which I couldn't get to work.

This fixes #14 and #15

RobinL commented 6 years ago

This looks good and works well. We're blocked from merging at the moment until we move the existing lambda-created policies into the inline s3-access policy (which probably means fully moving state over to the control panel db)

RobinL commented 6 years ago

This is now unblocked due to Aldo's work on IAM creds - users can now request access to their own inline IAM policy