Open cjrace opened 2 months ago
Bits I've spotted that we should update - please add if I've missed anything!
Cookie banner not working more generally is a separate issue to be dealt with in next leg of updates #67
Add a few extra bits I think we should check to the list above. Might be worth adding extra tabs to the example dashboard to test them with more easily?
For the cookie banner not working I think we should potentially just leave that for the separate issue to pick up?
And then final mop up steps
If we want to release an update to main after this, then also assuming we'll need to
Thanks Cam! I'll message the assignees in our teams and randomly assign bits to check/see if they're happy. Agreed cookies one can be removed and treated as separate issue. Would we want to merge to dev first along with the other changes in the issue log so we only need to do one CRAN release? Or if you think these changes are more urgently needed happy to see what we need to do to release it sooner 😄
Let's merge to dev first and then see where we're at?
I think I might have just resolved two of the ones I added already as I got a bit carried away and started testing things out straight away! The beta banner and back link ones I'll make a quick PR pointing at to the update-to-gds-v5.4 branch shortly for you / someone else to take a look at 😄
The GDS frontend is currently at v5.3.0, this package is currently on v4.something.
v5 was a big step change for a chunk of things. We should update the components in this package to match - expecting it will be a fairly big job to go through and check them all individually, so worth chunking up once the initial update of the CSS etc is on a branch.