search

moja-global / About_moja_global

About moja global and How We Work
Mozilla Public License 2.0
35 stars 33 forks source link

Add cppcheck and clang-tidy codequality checks as part of CI/CD #76

Closed Tlazypanda closed 3 years ago

Tlazypanda commented 4 years ago

Describe the solution you'd like Currently the pull request is not tested on whether it is following cpp style conventions and other code quality checks. Static analysis tools such as cppcheck and clang-tidy can help us check pull requests and have better code maintainability in the future.

Describe alternatives you've considered As per discussion with @kaskou we need to develop our own testing github actions to allow customization ahead. - https://github.com/Tlazypanda/cpp-clang-check is currently in preliminary stages and has been pre-released as a github actions on github marketplace.

We need to study the following existing tools to ensure this action has all these features - https://github.com/smay1613/cpp-linter-action https://github.com/deep5050/cppcheck-action

Tlazypanda commented 4 years ago

Just noting @kaskou @gmajan @Patamap Currently the preliminary action tool can be seen in action here - https://github.com/Tlazypanda/FLINT/pull/1 :sweat_smile: Needs to developed further to only flag specific errors as per our codebase

Tlazypanda commented 4 years ago

Update here: @kaskou approved initial action tool, now moving to the next stage of modifying to add flags in the action (for example allowing users to edit the action script to check for specific flags for cppcheck such as only performance or as desired) cc @gmajan @Patamap :v:

gmajan commented 4 years ago

@malfrancis @leitchy @mfellows is this in line with your discussion on Wednesday and can @Tlazypanda proceed? thx

stale[bot] commented 3 years ago

Hi, Thanks for raising an issue! We at moja global appreciate your concerns and views to help us improve. We capitalize on fostering a welcoming environment for all our contributors. This issue has not seen any activity for the past 30 days. If this Issue would not see any further updates in the next 7 days, it would be automatically closed. Please comment on the issue if you would like to discuss on this further. We truly appreciate your contributions and would love to hear your thoughts on the same!