moja-global / FLINT-UI

A experimental FLINT client, written in Vue, to provide an awesome user interface for configuring simulations using the FLINT.Cloud APIs.
flint-ui.vercel.app
Mozilla Public License 2.0
50 stars 89 forks source link

Migration: Migrated RothCOutput.vue to Vue 3 (Composition API) #370

Closed kamalbuilds closed 1 year ago

kamalbuilds commented 2 years ago

Pull Request Template

Description

Migration: Migrated RothCOutput.vue to Vue 3 (Composition API)

This PR fixes #338

Testing

Please instructions so we can verify your changes.

If our automated tests fail, please feel free to reach out to us by leaving a comment down below and we will be happy to take a look

Additional Context (Please include any Screenshots/gifs if relevant)

...

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flint-ui ❌ Failed (Inspect) Oct 10, 2022 at 7:31PM (UTC)
gcbm-editor ❌ Failed (Inspect) Oct 10, 2022 at 7:31PM (UTC)
kamalbuilds commented 2 years ago

@YashKandalkar Please review :smile:

shloka-gupta commented 2 years ago

@Palaksharma23 can you please take a look as well?

Palaksharma23 commented 2 years ago

Hey! @legendarykamal, can you please work on solving the deployment errors

kamalbuilds commented 2 years ago

hey @Palaksharma23 whenever I try to access it , I get this error image

kamalbuilds commented 2 years ago

@HarshCasper @chicken-biryani anything you can suggest so that I can debug this ?

shloka-gupta commented 2 years ago

Hey @legendarykamal feel free to reach out to @Palaksharma23 or @Janvi-Thakkar over slack!

YashKandalkar commented 2 years ago

@legendarykamal you can have a look at the CI / build run details for errors

kamalbuilds commented 2 years ago

Ok @YashKandalkar i will take a peek in 🚈

kamalbuilds commented 2 years ago

finally fixed the CI error :)

thisiskaransgit commented 2 years ago

hey @legendarykamal are you still working on it

kamalbuilds commented 2 years ago

yeah on it @thisiskaransgit just have to fix these build errors .

kamalbuilds commented 2 years ago

I rebased to fix the DCO and made changes to fix the build. Hopefully builds with no issues this time 🤞

kamalbuilds commented 2 years ago

Wohoo done! all checks green @YashKandalkar @chicken-biryani @HarshCasper 💯

HarshCasper commented 2 years ago

Wohoo done! all checks green @YashKandalkar @chicken-biryani @HarshCasper 💯

Where? The Vercel deployment still fails. Please take a look at @Crystalsage's comment and fix the issue he pointed out.

github-actions[bot] commented 1 year ago

This Pull Request has not seen any activity for the past 45 days. If this Pull Request would not see any further updates in the next 10 days, it would be automatically closed. Please tag a maintainer to have it reviewed and merged for you. We truly appreciate your contributions and would love to hear your thoughts on the same!

Janvi-Thakkar commented 1 year ago

Hello @legendarykamal, Please do let us know if you are still working on resolving the build failures.

Janvi-Thakkar commented 1 year ago

Hi @thisiskaransgit! As you were asking, you may continue this.