search

moja-global / FLINT-UI

A experimental FLINT client, written in Vue, to provide an awesome user interface for configuring simulations using the FLINT.Cloud APIs.
flint-ui.vercel.app
Mozilla Public License 2.0
50 stars 89 forks source link

feat : Replaced accordion component with Ui-library's #408

Closed thisiskaransgit closed 2 years ago

thisiskaransgit commented 2 years ago

Description

This PR fixes #384

Replaced the current accordion component with UI-library's accordion component

Testing

Changes are visible at : /flint/configurations/rothc

Additional Context (Please include any Screenshots/gifs if relevant)

Screenshot from 2022-09-23 00-59-21 Screenshot from 2022-09-23 01-00-05

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flint-ui ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 1:48PM (UTC)
gcbm-editor ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 1:48PM (UTC)
thisiskaransgit commented 2 years ago

@Janvi-Thakkar Kindly review the PR

Janvi-Thakkar commented 2 years ago

image

Janvi-Thakkar commented 2 years ago

@thisiskaransgit Please add margins as per requirements!

thisiskaransgit commented 2 years ago

If you are referring to the overlapping, This issue is fixed with #411 Screenshot from 2022-09-25 22-25-39

YashKandalkar commented 2 years ago

@thisiskaransgit Hi - I think the bottom margin/padding is still required. Please have a look. image