search

moja-global / FLINT

Full Lands INtegration Tool: a modular system to estimate greenhouse gas emissions and removals by the land sector
https://moja.global/
Other
57 stars 80 forks source link

Fix tables in Module wiki #103

Open aornugent opened 3 years ago

aornugent commented 3 years ago

What does the current documentation state? The module wiki has tables that are not formatted correctly.

Where is this stated? https://github.com/moja-global/FLINT/wiki/3.4-Module-Science

Why do you want to improve the statement? Fix the markdown syntax by adding extra spaces.

shloka-gupta commented 3 years ago

If I am not wrong, just markdown beautifier has to be applied to the document, right?

Can I go for it?

aornugent commented 3 years ago

Yes please!

shloka-gupta commented 3 years ago

So, I did the required changes,

but while creating a PR I am getting the message : remote: Permission to moja-global/FLINT.wiki.git denied to chicken-biryani. fatal: unable to access 'https://github.com/moja-global/FLINT.wiki.git/': The requested URL returned error: 403

shloka-gupta commented 3 years ago

These links say that : "GitHub doesn't support pull requests for the wiki repository, only the main repository" https://stackoverflow.com/questions/10642928/how-to-pull-request-a-wiki-page-on-github https://docs.github.com/en/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages

shubhamkarande13 commented 3 years ago

@chicken-biryani I guess that it is not possible to create a PR for a wiki on GitHub. Could you please make a zip file of the wiki folder and upload it to Google Drive and share it here, so that @aornugent can update the wiki from his end? ✌

@aornugent it seems that only users with write access to the repo can push updates to the wiki. 😅

mehabhalodiya commented 3 years ago

I have visited this link: https://github.com/moja-global/FLINT/wiki/3.4-Module-Science

And seen the first table was having some issue of formatting. I have tried to correct it as below. Let me know if it's alright so that I can complete further!

Preview: moja2

@aornugent Have a look!

shloka-gupta commented 3 years ago

Hey, @mehabhalodiya thank you for doing this!! 😃🎉

Could you put the changes of the wiki folder in a zip file and upload it to Google Drive and share the link over here, in the comment section, as stated by @shubhamkarande13 earlier? (As Github doesn't support PRs for the wiki repository.)

mehabhalodiya commented 3 years ago

@chicken-biryani Yes I will put it up but first let me know that is it the way you want the format?

shloka-gupta commented 3 years ago

@mehabhalodiya Yes. That is the correct format. However, I think there are a few more tables that require formatting. Just apply a markdown formatter to the whole document and the work will get done!

mehabhalodiya commented 3 years ago

https://drive.google.com/file/d/1oUWyhBPpA3DKAzH90cxXknXJl2Ha0QeD/view?usp=sharing

@chicken-biryani @shubhamkarande13 @aornugent PTAL!

apoorvthedude commented 3 years ago

Hi, Please someone mail to @aornugent to close the issue as the file is formatted by @mehabhalodiya.Now the wiki is in correct format. She has shared the file.