moja-global / moja_global_docs

Repository to host the moja global technical documentation
https://docs.moja.global/en/master/
Mozilla Public License 2.0
35 stars 67 forks source link

Fixes#117 Update README.MD #118

Closed ShaDe2312 closed 3 years ago

ShaDe2312 commented 3 years ago

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

HarshCasper commented 3 years ago

Hi @ShaDe2312 :wave:

Can you please run these commands:

git commit --amend --no-edit --signoff
git push --force-with-lease origin patch-1

This will fix the DCO.

ShaDe2312 commented 3 years ago

Hi. I did run those commands, in the second command it said:

$ git push --force-with-lease origin patch-1 error: src refspec patch-1 does not match any error: failed to push some refs to 'https://github.com/ShaDe2312/moja_global_docs.git'

Edit: To anyone who might face same issue, this happened because I made the changes initially on Github, in an (automatically created) branch names patch-1, and this branch didn't exist locally, leading to the error. It fixed when I used git switch patch-1 , and then ran the two commands again.

ShaDe2312 commented 3 years ago

@HarshCasper I think this is good to go

HarshCasper commented 3 years ago

@all-contributors bot please add @ShaDe2312 for documentation

allcontributors[bot] commented 3 years ago

@HarshCasper

I've put up a pull request to add @ShaDe2312! :tada: