search

moja-global / moja_global_docs

Repository to host the moja global technical documentation
https://docs.moja.global/en/master/
Mozilla Public License 2.0
35 stars 67 forks source link

Update git_and_github_guide.rst #144

Closed King-kay closed 3 years ago

King-kay commented 3 years ago

Added little detail to the develop section. fix 110 in ../FLINT/issues

shloka-gupta commented 3 years ago

@King-kay a good practice is to:

Request for a review after you feel that your work is done.

Here's how you can request for a review..

It's a repetitive process... You ask for a review, the PR either gets approved or you are asked to make some changes. Once you make the changes just ask for a review again.

You could also tag the person/people you've asked for a review from in the comment under the PR.

King-kay commented 3 years ago

@chicken-biryani Thanks ,that's why I posted it under the issue comment. followed the request for a review link and I did follow the process and it didnt work for me, so posted it in the comment. @chicken-biryani please could you help review?

shloka-gupta commented 3 years ago

Yes yes! Lgtm!