search

mojaie / MolecularGraph.jl

Graph-based molecule modeling toolkit for cheminformatics
MIT License
197 stars 29 forks source link

Don't specialize connectedcomponents for subgraphs #43

Closed timholy closed 3 years ago

timholy commented 3 years ago

The generic fallback gives the correct answer, but the specialization does not.

I made this PR in two commits; the first is the failing test, the second is a fix, to make it easy to replicate. Feel free to squash this when you merge.

I am not sure whether others should also have such specializations removed.