Closed hhaensel closed 2 years ago
@mojaie Are you going to release a new version once this PR is tested and merged?
Merging #63 (c54ccdf) into master (a0cc2ff) will decrease coverage by
0.06%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 76.20% 76.14% -0.07%
==========================================
Files 56 56
Lines 4942 4963 +21
==========================================
+ Hits 3766 3779 +13
- Misses 1176 1184 +8
Impacted Files | Coverage Δ | |
---|---|---|
src/sdfilereader.jl | 49.07% <0.00%> (-1.89%) |
:arrow_down: |
src/graph/shortestpath.jl | 96.72% <0.00%> (+0.05%) |
:arrow_up: |
src/draw/svg.jl | 75.50% <0.00%> (+0.09%) |
:arrow_up: |
src/graph/plaingraph.jl | 94.33% <0.00%> (+0.10%) |
:arrow_up: |
src/draw/draw2d.jl | 75.32% <0.00%> (+0.16%) |
:arrow_up: |
src/graph/isomorphism/edgeinduced.jl | 95.23% <0.00%> (+0.23%) |
:arrow_up: |
src/graph/connectivity.jl | 82.35% <0.00%> (+0.26%) |
:arrow_up: |
src/structurematch.jl | 75.00% <0.00%> (+0.50%) |
:arrow_up: |
src/graph/subgraphview.jl | 72.30% <0.00%> (+0.87%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a0cc2ff...c54ccdf. Read the comment docs.
Thank you very much and I'm sorry for very late response. It looks very nice. It will be merged soon, and I will make a new release.
Is it acceptable to rename GraphReaction
to GraphMolReaction
?
GraphMol
is a model name that might be replaced by a better one in the future, so I prefer the expression {model name}Reaction
for the reaction type.
Is it acceptable to rename
GraphReaction
toGraphMolReaction
?GraphMol
is a model name that might be replaced by a better one in the future, so I prefer the expression{model name}Reaction
for the reaction type.
Absolutely! 🚀
Thank you. I will make the commit and new release.