search

mojaie / MolecularGraph.jl

Graph-based molecule modeling toolkit for cheminformatics
MIT License
189 stars 27 forks source link

Delete Manifest.toml #78

Closed eahenle closed 1 year ago

eahenle commented 1 year ago

Deletes Manifest.toml and adds it to the .gitignore (reduces need to Pkg.resolve, especially in Pluto notebooks)

mojaie commented 1 year ago

Thank you very much! I'm not familiar with Pluto, but is it a significant inconvenience or performance loss? I'd like to keep Manifest.toml as a reference environment for unit test reproducibility.

eahenle commented 1 year ago

Eh, it's not a huge deal, so possibly not worth bothering. But, I think for what you want, you can have test/Project.toml and test/Manifest.toml, so that when you do Pkg.test() it builds according to those.

mojaie commented 1 year ago

Yes, it seems much better.

eahenle commented 1 year ago

I merged the Project.toml files and moved Manifest.toml into /test

Hmm, a test is failing on CI. I ran the tests on Julia 1.8 and they passed...

mojaie commented 1 year ago

Thank you very much! CI problem is maybe due to some GitHub action settings. I will fix it someday.