Closed tmcgrath325 closed 1 year ago
Thank you for the great idea!
I'm already working on Makie interface (see new_graph
and 'dev' branch)
Could you wait for the branch is merged to main branch?
As the dev branch is merged now, would it make sense to address this? I think this would indeed be a cool addition to this project. :)
Since @mojaie indicated that contributions to 3D drawing are welcome in #89, I made a pull request with some additional features (see #90).
New additions include the "stick" and "wire" plots shown above. I've also tried to make it easy to combine multiple molecules or display types:
julia> using GLMakie, MolecularGraph
julia> mol = sdftomol("assets/test/aspirin_3d.sdf");
julia> f = wire(mol); spacefilling!(mol, alpha=0.2); f
Thank you very much, it looks great! I could reproduce with also WGLMakie
Related: #74, #46
Since AbstractPlotting.jl is no longer supported, it seems like a good idea to update the 3D display to require Makie.jl instead. It also might be nice to be able to have some additional plotting options, like the stick and wire-frame displays here.
I've started to implement these while keeping the existing interface mostly intact:
I also wanted to add the option for a "stick" display...
...as well as a way to easily plot multiple molecules in a single figure:
Would you be interested in making these kinds of changes to the 3D display implementation? If so, I can put together a pull request with the work I've done so far.