search

mojaie / MolecularGraph.jl

Graph-based molecule modeling toolkit for cheminformatics
MIT License
189 stars 27 forks source link

name clash with Base.VERSION #92

Closed hhaensel closed 1 year ago

hhaensel commented 1 year ago

The latest version has a problem with exporting VERSION. Any usage of VERSION after loading MolecularGraph will fail.

My recommendation would be to either export MG_VERSION or don't export it at all (favoured). If people want to refer to a version number of MolecularGraph, it feels quite normal to call MolecularGraph.VERSION

mojaie commented 1 year ago

Thank you for catching that. MolecularGraph.VERSION looks better so I will simply remove the export.

hhaensel commented 1 year ago

Pleasure to help. It's such an excellent package!

BTW, are you interested in getting the lines of your drawings completely connected?

mojaie commented 1 year ago

What does "completely connected" mean? Improvements in the quality of molecule drawings are always welcome. Could you make a separate issue about it?