mojaloop / design-authority-project

This is the Issue and Decision Log for tracking mojaloop and related Designs
1 stars 2 forks source link

Approach for storing Invalid Requests for Prepare/Fulfils #9

Closed NicoDuvenage closed 2 years ago

NicoDuvenage commented 5 years ago

Request:

Current functional logic of the saveTransferPrepared facade is implemented so that a try-catch block wraps the entire logical insertion of the transfer, transferParticipant, transferExtension, ilpPacket, & transferStateChange. If any of those inserts fail, the catch will roll back the entire transfer. E.g. if the participant doesn't exist, the insertion into the transferParticipant table cause an error to be thrown thereby causing a complete roll-back.

The outcome being that no record is stored, and a new transferId can be retried.

Artifacts:

Decision(s):

Follow-up:

Dependencies:

Accountability:

Notes:

mdebarros commented 5 years ago

See decision made as part of https://github.com/mojaloop/design-authority/issues/29 as option 4 was selected which resolves this issue.