Features: AM-397 & AM-398

mojaloop / fraud_risk_management

Central repo for fraud and risk management development and specifications

Other

13 stars 7 forks source link

Features: AM-397 & AM-398 #198

Closed johanfol closed 3 years ago

johanfol commented 3 years ago

AM-397 & AM-398;
Added UML diagrams explaining gRPC and OpenFaaS issue. Fixes:
Fix CRSP to asynchronously send requests to Rule Engines;

CLAassistant commented 3 years ago

All committers have signed the CLA.

johanfol commented 3 years ago

@elnyry-sam-k created an issue on the cla-assitant - I'm unable to sign the CLA for some reason. Details here: https://github.com/cla-assistant/cla-assistant/issues/701

I've signed it before, but working from a new PC it wants me to sign again.

Is it fine if I merge this PR even though it thinks I didn't sign?

elnyry-sam-k commented 3 years ago

@johanfol - any chance your other machine is using a different GitHub ID (or isn't configured to use one)?

elnyry-sam-k commented 3 years ago

@elnyry-sam-k created an issue on the cla-assitant - I'm unable to sign the CLA for some reason. Details here: cla-assistant/cla-assistant#701

I've signed it before, but working from a new PC it wants me to sign again.

Is it fine if I merge this PR even though it thinks I didn't sign?

Its fine with merging for now - if its blocking your work

johanfol commented 3 years ago

@johanfol - any chance your other machine is using a different GitHub ID (or isn't configured to use one)?

Same GitHub ID - if you click on my UserID you should see all my previous PR's to the same repository, with this GitHub ID.