search

mojaloop / helm

Helm Charts. Helm repo http://mojaloop.io/helm/repo/index.yaml
https://mojaloop.io
Other
20 stars 60 forks source link

feat: config override #630

Closed kalinkrustev closed 3 months ago

kalinkrustev commented 3 months ago

What is going on here is that in the values one can specify something like this:

configOverride:
  .EVENT_SDKrc:
    # configuration overrides for event sdk
  .CLEDGrc:
    # configuration overrides for central ledger

Then these will be volume-mounted as files .EVENT_SDKrc and .CLEDGrc within the /opt/app dir, where they will be processed by the rc module. The configuration properties will work as overrides on top of the default.json. This is a way to apply individual changes to configuration properties in IAC, instead of copying the whole configuration from the default.json file.

kalinkrustev commented 3 months ago

This looks good to me. Do you want to add empty configOverride section with some comments in the values files?

Added the section in 88aa64e43db06afc332a83cc6ddc13e1d720167d

kalinkrustev commented 3 months ago

@elnyry-sam-k are you OK with merging this to master?

There are a lot of changed files, but they all do the same for each chart:

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud