mojaloop / mojaloop-specification

This repo contains the specification document set of the Open API for FSP Interoperability
https://docs.mojaloop.io/api
Other
20 stars 40 forks source link

Solution Proposal: Notify Payee FSP in case of failure to commit on a Switch #106

Closed elnyry-sam-k closed 1 year ago

elnyry-sam-k commented 2 years ago

[103] -- [Notify Payee FSP in case of failure to commit on a Switch]


Open API for FSP Interoperability -- Solution Proposal

Table of Contents

1. Preface


This section contains basic information regarding the solution proposal.

1.1 Solution Proposal Information

Change Request ID 103
Change Request Name Notify Payee FSP in case of failure to commit on a Switch
Prepared By Sam Kummary, ModusBox
Solution Proposal Status In review [x] / Approved [ ] / Rejected [ ]
Approved/Rejected Date

1.2 Document Version Information

Version Date Author Change Description
1.0 2021-12-14 Sam Kummary Initial version of the solution proposal. Sent out for review.

2. Change Request


2.1 Background

This issue is about handling error cases that happen during processing of PUT /transfers/{ID} calls. Specifically, about how a Switch should deal with a scenario when a validation error occurs during processing of a PUT /transfers/{ID} call.

Here's the change request: https://github.com/mojaloop/mojaloop-specification/issues/103 for further details of the requirement / problem statement.

It was agreed by the CCB to adopt the approach below (as can be seen in the comments of the above change request)

A new method of notification with HTTP PATCH on /transfers/{ID}/error will be introduced, when there is an internal validation error (not schema validation) in the PUT /transfers/{ID} sent from the Payee FSP, both when RESERVED and COMMITTED is used as transferState.

To avoid major changes with minor versions, here's the adopted approach:

3. Proposed Solution


Pull request: https://github.com/mojaloop/mojaloop-specification/pull/109 shows the changes proposed

4. Other Considered Solutions


One of the alternatives considered was proposed for 2.0 as a breaking change.

Version 2.0 of the API adds the same possibility of sending PATCH /transfers/{ID}/error from the Switch in case the Payee FSP is using PUT /transfers/{ID} with RESERVED and there is an error.

henrka commented 1 year ago

@elnyry-sam-k, I think this one can be closed?

elnyry-sam-k commented 1 year ago

Yes @henrka , thanks!

henrka commented 1 year ago

Closed as discussed above.