Closed lewisdaly closed 4 years ago
It is Cool! @lewisdaly 👍 Nice cleanup and very fine setup for ts driven tests. Few not very important comments. The data preparation sections are elaborative ... ;-) What about extracting data to external files... ?
Thanks @eoln . I'll touch up the _wait4_all.js
script as you suggest.
For the "data preparation sections", do you mean within the tests themselves? If so, I do agree that the data preparation stuff can live elsewhere. I mainly just didn't want to prematurely optimize especially since we don't know exactly what form these tests will take at the moment.
Indeed I can imagine some sort of TestClient library we will write in the future to invoke the http requests with some nice helpers etc.