Updated services to handle GET party accounts.

[kleyow]

I'm just realizing (maybe I'm mistaken) that

• sdk-scheme-adapter doesn't have it's own /parties endpoint so that a dfsp back-end can get party accounts synchronously?
• mojaloop-simulator doesn't seem to have a scenario that covers if a dfsp want to query the ALS for a party?

So I'm not sure how to write tests. Maybe @bushjames you can guide me.

[lewisdaly]

Regarding testing, let's sync up about this. @elnyry might have some ideas as well.

Hmm, looks like e2e tests are failing.

Also: on the version of the -pisp docker images, I was thinking we should use the same versioning scheme we are using with everything else, and it captured in the package.json of pi.sprint.increment.

[eoln]

Also: on the version of the -pisp docker images, I was thinking we should use the same versioning scheme we are using with everything else, and it captured in the package.json of pi.sprint.increment.

I wouldn't bump version in package.json as long as pisp/master branch isn't merged with master - the version bumping should only happen before the merge with master. Instead in the tag, I would add one additional number (filter tag regexp allows it) which could allow us to have versioned pisp images -> git tag -a v10.3.1.<pisp_counter>-pisp; git push --follow-tags <upstream>. I did this for transaction-request-service.

[lewisdaly]

@eoln sure we can do it that way if you'd like. Just keep in mind that since the 10.3.1 isn't really a version in the semantic sense, it represents the PI and sprint (then number of changes).

[lewisdaly]

Hey @kleyow I think you can leave the sdk-scheme-adapter tests for now. We spoke on thursday in a little more detail of how the sdk-scheme-adapter works with state machines etc.

I've got some design documents that should clear up some of the interactions between PISPs and the sdk-scheme-adapter, and I think we can take care of the GET /parties tests as a part of the other sdk-scheme-adapter changes.

[kleyow]

@lewisdaly Sounds good. Let me address the failing e2e test and lets merge this in.

I have the sdk-scheme-adapter /parties in the works already, but I'm for merging this in.

[kleyow]

re: versioning there seems to be some concerns on this and across other services. admittedly I'm not sure what is the best course of action. maybe a call?

fixed that one failing test! whew... lmk if you want to hold this back because of versioning or if this is good to merge.

@lewisdaly @eoln @sridharvoruganti

[kleyow]

Versioning/image concerns addressed. @eoln @lewisdaly @sridharvoruganti

[kleyow]

Woooo :ship: happy to get this merged!