search

mojaloop / pisp-project

PISP - Payment Initiation Service Provider integration with Mojaloop
Other
9 stars 12 forks source link

How does a PISP identify the response of party lookup uniquely? #46

Open stevenwjy opened 4 years ago

stevenwjy commented 4 years ago

Problem

Upon receiving PUT /parties/..., a PISP does not know which request (i.e., `GET /parties/...``) it corresponds to. Hence, a PISP needs to be able to query all lookups that haven't gotten a response with the provided identifier. Afterward, suppose the query result contains more than one items, then it will make some other queries couldn't find a match.

Proposed solution

It would be better for GET /parties/... to return a requestId that will also be attached in PUT /parties/... to identify a response to a particular request uniquely.

lewisdaly commented 4 years ago

@stevenwjy you mentioned something about the trace headers in a call the other day. Would this potentially solve your needs?

I don't have much more info than this link: https://docs.mojaloop.io/documentation/mojaloop-technical-overview/event-framework/#4-tracing-design but perhaps @elnyry-sam-k might be able to help

stevenwjy commented 4 years ago

Yes, I think for now it could be used as an alternative for those who want to identify which request is associated with a particular callback... However, I am actually also not really sure about this because the last time I talked with @jgeewax about this, JJ said that the tracing headers should not be used to carry such a responsibility.

Hence, I think it may be a good idea to keep this issue open for a while until we come into an agreement....

lewisdaly commented 4 years ago

Yeah for sure. This is actually up for discussion in today's DA meeting, so I will be able to post an update to this ticket after that.