mojaloop / pisp-project

PISP - Payment Initiation Service Provider integration with Mojaloop
Other
9 stars 12 forks source link

chore: remove extra hosts from compose #99

Closed kleyow closed 3 years ago

kleyow commented 4 years ago

@lewisdaly can you test this on macos and run e2e tests to see if they pass for me so I can double check that this was isolated to linux setups.

lewisdaly commented 4 years ago

@lewisdaly can you test this on macos and run e2e tests to see if they pass for me so I can double check that this was isolated to linux setups.

@kleyow yeah will do

lewisdaly commented 4 years ago

@kleyow failed for me with the following:

 FAIL  test/e2e/P2PTransfer.test.ts
  Peer to Peer transfer
    ✕ Performs a P2P transfer from Alice -> Bob (513 ms)
    ✕ Performs a P2P transfer from Bob -> Alice (456 ms)
    ✕ Rejects an E2E Transfer (49 ms)

  ● Peer to Peer transfer › Performs a P2P transfer from Alice -> Bob

    expect(received).toEqual(expected) // deep equality

    Expected: ObjectContaining {"amount": "100", "currentState": "COMPLETED", "from": ObjectContaining {"idType": "MSISDN", "idValue": "123456789"}, "fulfil": ObjectContaining {"transferState": "COMMITTED"}, "quoteResponse": ObjectContaining {"transferAmount": {"amount": "100", "currency": "USD"}}, "to": ObjectContaining {"idType": "MSISDN", "idValue": "987654321"}}
    Received: undefined

      58 |     // Assert
      59 |     expect(result.status).toBe(200)
    > 60 |     expect(result.data.scenario1.result).toEqual(expect.objectContaining(expected))
         |                                          ^
      61 |   })
      62 |
      63 |   it('Performs a P2P transfer from Bob -> Alice', async (): Promise<void> => {

      at Object.<anonymous> (test/e2e/P2PTransfer.test.ts:60:42)

  ● Peer to Peer transfer › Performs a P2P transfer from Bob -> Alice

    expect(received).toEqual(expected) // deep equality

    Expected: ObjectContaining {"amount": "100", "currentState": "COMPLETED", "from": ObjectContaining {"idType": "MSISDN", "idValue": "987654321"}, "fulfil": ObjectContaining {"transferState": "COMMITTED"}, "quoteResponse": ObjectContaining {"transferAmount": {"amount": "100", "currency": "USD"}}, "to": ObjectContaining {"idType": "MSISDN", "idValue": "123456789"}}
    Received: undefined

      112 |     // Assert
      113 |     expect(result.status).toBe(200)
    > 114 |     expect(result.data.scenario1.result).toEqual(expect.objectContaining(expected))
          |                                          ^
      115 |   })
      116 |
      117 |   it('Rejects an E2E Transfer', async (): Promise<void> => {

      at Object.<anonymous> (test/e2e/P2PTransfer.test.ts:114:42)

  ● Peer to Peer transfer › Rejects an E2E Transfer

    expect(received).toEqual(expected) // deep equality

    Expected: ObjectContaining {"statusCode": "5105", "transferState": ObjectContaining {"amount": "5105", "amountType": "SEND", "currency": "USD", "currentState": "ERROR_OCCURRED"}}
    Received: undefined

      155 |     // Assert
      156 |     expect(result.status).toBe(200)
    > 157 |     expect(result.data.scenario1.result).toEqual(expect.objectContaining(expected))
          |                                          ^
      158 |   })
      159 | })
      160 |

      at Object.<anonymous> (test/e2e/P2PTransfer.test.ts:157:42)

 FAIL  test/e2e/PISP_3PR_Transfer.test.ts
  /thirdpartyTransaction: partyLookup->initiate->approve
    ✕ transactionRequestState should be ACCEPTED (97 ms)

  ● /thirdpartyTransaction: partyLookup->initiate->approve › transactionRequestState should be ACCEPTED

    Request failed with status code 500

      at createError (node_modules/axios/lib/core/createError.js:16:15)
      at settle (node_modules/axios/lib/core/settle.js:17:12)
      at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:236:11)
lewisdaly commented 4 years ago

I got the same failures when I ssh'd into circleci as well