mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
24 stars 15 forks source link

SDK-Scheme-Adapter is missing/incorrect bulkTransferState on a PUT /bulkTransfer/{id} Callback by the PayeeFSP #2816

Closed mdebarros closed 2 years ago

mdebarros commented 2 years ago

Summary: SDK-Scheme-Adapter is missing bulkTransferState on a PUT /bulkTransfer/{id} Callback by the PayeeFSP

Example callback response from a PayeeFSP SDK-Scheme-Adapter:

{"ts":"2022-07-08T15:32:49.450Z","msg":"Executing HTTP PUT: {\n  reqOpts: {\n    method: 'PUT',\n    uri: 'http://bulk-api-adapter.moja2.test.mojaloop.live/bulkTransfers/764ff0d8-87d9-4ce1-a1ea-f25a736784e3',\n    headers: {\n      'content-type': 'application/vnd.interoperability.bulkTransfers+json;version=1.0',\n      date: 'Fri, 08 Jul 2022 15:32:49 GMT',\n      'fspiop-source': 'mojapayeefsp',\n      'fspiop-destination': 'testingtoolkitdfsp',\n      'fspiop-http-method': 'PUT',\n      'fspiop-uri': '/bulkTransfers/764ff0d8-87d9-4ce1-a1ea-f25a736784e3',\n      'fspiop-signature': '{\"signature\":\"OputKbvicDMPdNnaaQDH5ZWHXzb64wWJqknLAduWWkJ1dVAF9kZR_eZZy5j4UwqfslUgHEdH6hbWM57ncyW1re_0aOSgsfLAZxelY8W1CK_LNE403XehiTHjUYX6ZLPXAaJMD-5RmzGdgYIkWfKFnG1UxC6_EruHdpppPUkEINiQhuiXLZK4kWAfefdG96UWvnRnIsgjzN3vdumguP5KcjgzimY60R3XeS-drJQOeGBU12ifl2XHmK0Z_OxadtvhByFwMkNxLpGrz1bk209PHPhFvqc-QqSN6BS5YLLYsaVoP7IGeRASOdwk7Nm0_CdYZ4CTaQWssbuM2mhs_qqksA\",\"protectedHeader\":\"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvYnVsa1RyYW5zZmVycy83NjRmZjBkOC04N2Q5LTRjZTEtYTFlYS1mMjVhNzM2Nzg0ZTMiLCJGU1BJT1AtSFRUUC1NZXRob2QiOiJQVVQiLCJGU1BJT1AtU291cmNlIjoibW9qYXBheWVlZnNwIiwiRlNQSU9QLURlc3RpbmF0aW9uIjoidGVzdGluZ3Rvb2xraXRkZnNwIiwiRGF0ZSI6IkZyaSwgMDggSnVsIDIwMjIgMTU6MzI6NDkgR01UIn0\"}'\n    },\n    body: '{\"completedTimestamp\":\"2022-07-08T15:32:49.448Z\",\"individualTransferResults\":[{\"transferId\":\"a760409f-87c7-41e2-a3e4-b5bf8e1e2b59\",\"fulfilment\":\"tChMwYE5Zw9ZDiU6cUQyeLmReAE55dG74MJKHPWNjvs\"},{\"transferId\":\"97e27ae3-1698-4c1c-9adf-b651030045c2\",\"fulfilment\":\"tChMwYE5Zw9ZDiU6cUQyeLmReAE55dG74MJKHPWNjvs\"}]}',\n    qs: {},\n    agent: '[REDACTED]'\n  }\n}","ctx":{"simulator":"mojapayeefsp","hostname":"moja2-sim-mojapayeefsp-scheme-adapter-5f94b87479-62fs6","app":"mojaloop-connector-inbound-api","component":"api","request":{"id":"cuddly-moldy-tangy-flower","path":"/bulkTransfers","method":"POST"}}}

The above request is missing the bulkTransferState field.

Severity: High

Priority: Critical

Expected Behavior SDK-Scheme-Adapter should contain bulkTransferState on a PUT /bulkTransfer/{id} Callback by the PayeeFSP

Steps to Reproduce

  1. Deploy Helm Chart v14.0.0-rc
  2. Run Helm Test and monitor Bulk Test Collection Results

Specifications

Notes:

mdebarros commented 2 years ago

Helm test results for https://github.com/mojaloop/sdk-scheme-adapter/releases/tag/v18.0.0:

Test Result: PASSED
Test Suite: GP Tests
Environment: moja2.test.mojaloop.live
Total assertions: 2573
Passed assertions: 2573
Failed assertions: 0
Total requests: 587
Total test cases: 129
Passed percentage: 100.00%
Started time: Tue, 12 Jul 2022 09:41:38 GMT
Completed time: Tue, 12 Jul 2022 09:44:48 GMT
Runtime duration: 190158 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja2.test.mojaloop.live
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Tue, 12 Jul 2022 09:45:03 GMT
Completed time: Tue, 12 Jul 2022 09:45:26 GMT
Runtime duration: 23773 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Thirdparty Tests
Environment: moja2.test.mojaloop.live
Total assertions: 21
Passed assertions: 21
Failed assertions: 0
Total requests: 20
Total test cases: 8
Passed percentage: 100.00%
Started time: Tue, 12 Jul 2022 09:46:02 GMT
Completed time: Tue, 12 Jul 2022 09:46:07 GMT
Runtime duration: 4324 ms

View Report