mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
22 stars 15 forks source link

To fix: hub operator not able to approve a participant's contact info change request & participant's status change request #3891

Closed SithuKyaw-Thitsaworks closed 1 month ago

SithuKyaw-Thitsaworks commented 2 months ago

Summary:

  1. In participant's detail page, the contact info change request approval function is not working properly
  2. In participant's detail page, hub operator is not able to approve a participant's status request to enable a participant.

Severity: Medium

Priority: Medium

Expected Behavior

  1. A hub operator should be able to approve a participant's contact info change request. After a successful approval, the status of the record should change from "Pending" to "Approved by user_name_and_date_time".
  2. A hub operator should be approve a participant's status change request to enable or disable.

Steps to Reproduce For participant's contact info approval bug

  1. Create a contact info change request for a participant with a user
  2. Log in with another user and approve the previously created contact info status change request

    For participant's status approval bug

  3. Click "Disable" button to create a status change request for a participant at participant's detail page.
  4. Log in with another user and click "approve" button in the change request list for the previously created request.

Specifications

Notes:

elnyry-sam-k commented 1 month ago

@SithuKyaw-Thitsaworks can we please follow the bug template please: https://github.com/mojaloop/project/issues/new?assignees=&labels=bug&projects=&template=bug_report.md&title=

Thank you!

SithuKyaw-Thitsaworks commented 1 month ago

Sure @Sam, please let me update the ticket as the bug template.

YminOo commented 1 month ago

QA pass for this ticket.

User can approve/reject the contact info. Create the contact information with user role

Screenshot 2024-05-09 at 10.44.07 AM.png

Approve the request with admin role

Screenshot 2024-05-09 at 10.44.39 AM.png Screenshot 2024-05-09 at 10.45.12 AM.png

Reject the request with user role

Screenshot 2024-05-09 at 10.59.29 AM.png Screenshot 2024-05-09 at 11.00.10 AM.png

User can successfully enable and disable the participant status.

Screenshot 2024-05-09 at 10.24.05 AM.png

Disable the participant with user role

Screenshot 2024-05-09 at 10.24.11 AM.png Screenshot 2024-05-09 at 10.24.16 AM.png

Approved the request with admin role

Screenshot 2024-05-09 at 10.26.26 AM.png

Participant status is changed to Disable (Inactive)

Screenshot 2024-05-09 at 10.26.30 AM.png

Enable the participant with admin role

Screenshot 2024-05-09 at 10.26.38 AM.png

Approved the request with user role

Screenshot 2024-05-09 at 10.41.29 AM.png Screenshot 2024-05-09 at 10.41.52 AM.png