mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
22 stars 15 forks source link

Net Debit Cap with percentage calculation is not working properly #3895

Closed NawYinmin closed 1 month ago

NawYinmin commented 1 month ago

Summary: When user create the Net Debit Cap with percentage and approve this, NDC amount is not recalculate and shown 0. It must be calculated according to the related percentage.

Severity: Medium

Priority: Medium

Expected Behavior If the user add 1 % to the NDC percentage, then the NDC amount calculation will be 1 % of the settlement amount after the user approve the request.

Steps to Reproduce

  1. Create the Net Debit Cap request with percentage with one user
  2. Approve that request with another user and check for the NDC calculation is correct according to the related percentage of the settlement account

Specifications

Notes:

ZweHMyat commented 1 month ago

This is fixed now. Here is the PR. https://github.com/mojaloop/participants-bc/pull/31/files