search

mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
23 stars 15 forks source link

[fx][quoting-service] 15.8.0-snapshot.21 of quoting service fx functionality breaks GP tests #3951

Open kleyow opened 3 months ago

kleyow commented 3 months ago

Summary: A regression is introduced between versions of the quoting service 15.8.0-snapshot.15 and 15.8.0-snapshot.21

Failing tests: collections/hub/golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participant.json I believe this failure to be attributed to https://github.com/mojaloop/quoting-service/commit/1b57edc43ca28b2a8edd2b6329f79c041339e9fa#diff-5279fc369708a0f87ae15695811384dcd7a13ee54143c0f51771895e13d399d3L172

This call used to send a callback with ErrorHandler.Enums.FSPIOPErrorCodes.DESTINATION_FSP_ERROR (3201) since LOCAL_ENUM.PAYEE_DFSP is specified. With it's removal the code falls down to this.db.getParticipantByName(quoteRequest.payee.partyIdInfo.fspId), with no enum specified giving a more generic 3200 error.

collections/hub/golden_path/feature_tests/Active_Inactive_participants/active_and_inactive_participants_accounts.json

I believe this failure to be attributed to https://github.com/mojaloop/quoting-service/commit/1b57edc43ca28b2a8edd2b6329f79c041339e9fa#diff-5279fc369708a0f87ae15695811384dcd7a13ee54143c0f51771895e13d399d3L172 as well. With the removal of the Payee validation the payer no longer receives an error call back. The original POST /quotes would have been successfully forwarded only to error out in the PUT quotes to where the validation has been moved to.

https://github.com/mojaloop/quoting-service/commit/1b57edc43ca28b2a8edd2b6329f79c041339e9fa#diff-5279fc369708a0f87ae15695811384dcd7a13ee54143c0f51771895e13d399d3R209

collections/hub/golden_path/bug fixes/Tests for Bugfix #990 and #1016 - Quotes.json

I believe this test the validation being moved also attributes to this test failure. Severity: (Low, Medium, High)

Priority: (Critical, Medium, Low)

Expected Behavior

Steps to Reproduce

  1. Deploy mojaloop with 15.8.0-snapshot.21 quoting service
  2. Run GP

Specifications

Notes: