search

mojaloop / project

Repo to track product development issues for the Mojaloop project.
Other
22 stars 15 forks source link

Errors from FXP Quotes are not reaching the HUB #3986

Open sri-miriyala opened 4 days ago

sri-miriyala commented 4 days ago

Summary: As a QA when I try testing the FX functionality in the environment for the first time, I see the errors are not forwarding to the payer as expected. The FX backend (TTK) is sending the error according to the rule set up, but it is failing in FX SDK.

Severity: (Low, Medium, High)

Priority: (Critical, Medium, Low)

Expected Behavior The errors from FXP to process successfully and reach the payer or/and payee according to the scenario. FX quote errors and FX transfers errors both are failing in the same way.

Steps to Reproduce

  1. Run test from here: https://github.com/mojaloop/testing-toolkit-test-cases/blob/feat/fx-impl/collections/pm4ml/fx_golden_path/feature_tests/negative_scenarios/fxp_error.json
  2. Observe the logs in FX SDK

Specifications

Notes:

vijayg10 commented 18 hours ago

This is a minor issue and I fixed it in this commit https://github.com/mojaloop/sdk-scheme-adapter/commit/36057c41f23096f239a8a89ddcc00cd446499a24

The snapshot version is v23.6.0-snapshot.1 A new tag is created in pm4ml helm https://github.com/pm4ml/mojaloop-payment-manager-helm/releases/tag/v9.2.0-fx.5 and the helm chart mojaloop-payment-manager-9.2.1-snapshot.2.tgz is available for deployment