Summary:
In the helm charts at centralledger/chart-service/templates/ingress.yaml, the ingress hosts are hardcoded to refer to .Values.ingress.hosts.api:
Which makes it difficult to configure the central-ledger on a custom domain while retaining the ability to reach the central-ledger using the central-ledger.local hostname.
Severity:
Low
Priority:
Low
Expected Behavior
The ingress hosts should be applied dynamically, such as in ml-api-adapter/chart-service/templates/ingress.yaml:
I'd say it's still a valid issue, but really, it's much easier for users to bring their own ingress than mess around with our 7,000 line long values.yml file
Summary: In the helm charts at
centralledger/chart-service/templates/ingress.yaml
, the ingress hosts are hardcoded to refer to.Values.ingress.hosts.api
:This makes it impossible to pass in a values file that specifies 2 or more hosts, for example:
Which makes it difficult to configure the central-ledger on a custom domain while retaining the ability to reach the central-ledger using the
central-ledger.local
hostname.Severity: Low
Priority: Low
Expected Behavior The ingress hosts should be applied dynamically, such as in
ml-api-adapter/chart-service/templates/ingress.yaml
:This would allow us to specify multiple hosts to create ingress rules for.
Steps to Reproduce
helm upgrade -f ./ingress.values.yml --repo http://mojaloop.io/helm/repo dev mojaloop
central-ledger.local
entry instead of adding a new rule:(this snippet is taken from the dashboard)
Specifications
Notes: