search

mojbro / gocoa

Go bindings for the Cocoa framework to build macOS applications
MIT License
68 stars 17 forks source link

Adding Support for NSProgressIndicator #1

Closed phaus closed 5 years ago

phaus commented 5 years ago

For a small application, I needed a progress indicator. So after some hours, I was able to add this to the code. I also updated the helloworld example.

mojbro commented 5 years ago

Amazing! I was not aware anyone was using this project. I'll have a closer look at the PR and merge it soon. Hope it works well for your project. This makes me inspired to get back to this project and develop it further. @phaus

phaus commented 5 years ago

I am currently refining the UI a little bit more. So please wait with this merge - if you plan to do merge :-). This project was a great start for my purpose :-).

phaus commented 5 years ago

Okay. Done with my updates. The behavior is now like expected :-)

phaus commented 5 years ago

I guess it will be difficult to have correct go dependencies within forks :-). I set them to this repository ;-).

mojbro commented 5 years ago

Looovely!

mojbro commented 5 years ago

@phaus I added you as a collaborator if you want to push directly to this repo without having to go through the fork/pull request process. (Although I like the pull request concept for the review stage)

phaus commented 5 years ago

I will go with feature branches an pull requests anyway. But doing it within the same repo makes it easier. Thx for the invite :-).