mojira / mojira-discord-bot

🎮 A Discord bot for linking to and providing information about Mojira tickets

https://discord.gg/rpCyfKV

GNU General Public License v3.0

19 stars 9 forks source link

Update to discord.js v13 (third try) #244

Closed violine1101 closed 2 years ago

violine1101 commented 3 years ago

Previous PRs:

224, #236

Reverted in:

235, #243

This change requires more testing and changes to the codebase to ensure it works properly with discord.js v13.

mdashlw commented 2 years ago

What's the status of this?

violine1101 commented 2 years ago

Essentially, upgrading to discordjs v13 broke stuff and we don't know why it broke stuff or how to fix it.

I'm currently in the process of rebasing everything, and then I'll merge this after having tested it locally.

chandler05 commented 2 years ago

I noticed that reactions to the pending request seem to appear slower when a request is added. Is this just my bot or does it happen for yours as well?

violine1101 commented 2 years ago

I'm not sure. It's always a little delayed, however possibly the delay has been increased with v13. I think for our purposes it's fine.

In the future it'd be nice to replace this with buttons anyway, but we aren't that far yet.

violine1101 commented 2 years ago

Forgot to include co-authors in the commit, new commit is 20ee09e08777f826b3c708a69bcff814e8911e34 (no other changes)