search

mojira / mojira-discord-bot

🎮 A Discord bot for linking to and providing information about Mojira tickets
https://discord.gg/rpCyfKV
GNU General Public License v3.0
19 stars 9 forks source link

Remove renames from #java-fixes #255

Closed mdashlw closed 2 years ago

mdashlw commented 2 years ago

https://canary.discord.com/channels/647810384031645728/647810384622911490/910962936867074139

SPGoding commented 2 years ago

The 1.18 rename feed (https://discord.com/channels/647810384031645728/666349583227682819/915270862976974889) is 3 whole minutes earlier than the release feed, might worth keeping it :thinking:

mdashlw commented 2 years ago

The 1.18 rename feed (https://discord.com/channels/647810384031645728/666349583227682819/915270862976974889) is 3 whole minutes earlier than the release feed, might worth keeping it 🤔

Honestly, if a couple of minutes mattered, it would have used a more aggressive polling than 30 seconds We also had https://canary.discord.com/channels/647810384031645728/741600360619049000/915254372416487434 an hour before the release

violine1101 commented 2 years ago

We also have the #version-feed channel now which shows all renames anyway, albeit on a longer delay.

So I think it makes sense to only have released and unreleased for the snapshot feeds, but also decrease the delay for the version feed.

violine1101 commented 2 years ago

I've now merged this manually in e0340a3ac73b8d783323287b67eb951756e3b09b due to my mentioned additional changes + issues with the GitHub CI workflow for external branches.

Thanks for the PR!