search

mojo-data / arrow.mojo

Apache Arrow in Mojo🔥
Apache License 2.0
42 stars 2 forks source link

move to mojo-24.4 add destructor #1

Closed jdupl123 closed 5 months ago

jdupl123 commented 5 months ago

Implement the AnyType trait and update type to be compatible with mojo 24.4.

image

currently returns this strange error when I run the tests

@sa- any thoughts on this error?

sa- commented 5 months ago

Yeah I've opened this issue for it: https://github.com/modularml/mojo/issues/2956

It also exists on main

sa- commented 5 months ago

Could you please make a new PR with just the destructor? That's a change that can be merged in quick

jdupl123 commented 5 months ago

Could you please make a new PR with just the destructor? That's a change that can be merged in quick

I did a force push on this one. does that work? or would you prefer to stay on the older mojo, with just the destructor?

sa- commented 5 months ago

This is good! We can merge when it compiles

jdupl123 commented 5 months ago

compiles now. WIP for c data interface is at https://github.com/mojo-data/arrow.mojo/pull/2

sa- commented 5 months ago

Thanks!