search

mojo-data / arrow.mojo

Apache Arrow in Mojo🔥
Apache License 2.0
31 stars 4 forks source link

Dev setup takes a long time #23

Closed sa- closed 2 weeks ago

sa- commented 2 weeks ago

source: https://github.com/mojo-data/arrow.mojo/pull/21#discussion_r1641359528

Making pyenv an optional but recommended dependency should suffice. Switching from poetry to uv will allow people install venv's using pip

martinvuyk commented 2 weeks ago

Hi, thanks a lot for the changes. Deleted and tried again and it works with python 3.10 with no hiccups. just did (less than 2 minutes):

Other than that the tests run fine

sa- commented 2 weeks ago

Ah uv is not a python package it's a rust tool. I think you could install it via pip but I'm not sure why one would. You can see the installation instructions

If you are creating your own venv and installing via pip then you actually don't need UV.

Alright it fails makefile assumes the folder is called .venv and not venv. I can add a note for this

Also virtualenv is deprecated. venv comes with Python already. If the venv is recreated on your machine with python3 -m venv .venv everything should work

sa- commented 2 weeks ago

I'm closing this issue for now, but if make setup doesn't work after recreating the venv following the above instructions then feel free to reopen the issue. The README is also updated to include this detail

martinvuyk commented 2 weeks ago

assumes the folder is called .venv and not venv

uv is creating a .venv folder though, but now that I see it it says python 3.11 and I'm running on 3.10 globally, so maybe it's because of that. Anyway, testing works which is the most important thing :)

petacube commented 2 weeks ago

base) $make setup Using Python 3.11.6 interpreter at: /usr/bin/python3 Creating virtualenv at: .venv Activate with: source .venv/bin/activate

Installing python dependencies

Resolved 11 packages in 15.41s Downloaded 3 packages in 4.02s Uninstalled 3 packages in 26ms Installed 3 packages in 8ms

Installing pre-commit hooks

make: ./.venv/bin/pre-commit: No such file or directory make: *** [Makefile:24: setup] Error 127

On Sun, Jun 16, 2024 at 11:41 AM Samay Kapadia @.***> wrote:

Ah uv is not a python package it's a rust tool. I think you could install it via pip but I'm not sure why one would. You can see the installation instructions

If you are creating your own venv and installing via pip then you actually don't need UV.

Alright it fails makefile assumes the folder is called .venv and not venv. I can add a note for this

— Reply to this email directly, view it on GitHub https://github.com/mojo-data/arrow.mojo/issues/23#issuecomment-2171747662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHF6KSC7LSEADF3NDFAIR3ZHWW2NAVCNFSM6AAAAABJMNWHJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRG42DONRWGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>