mojoblanco / NUBAN

Algorithm for validating NUBAN
36 stars 40 forks source link

Breaking down this repo into small individual repos #14

Open subomi opened 7 years ago

subomi commented 7 years ago

I'm in need of this validation for python only. As am building a app that requires account number validation with django. I suggest we can break this individual implementation into individual repos because

  1. Cloning this whole repo is a huge waste for me. Containing lots of 'the same code' I don't need.
  2. Package management issues, breaking away and hosting on npm or pypi allows me to add this as dependencies and update easily

Thanks!

mojoblanco commented 7 years ago

Hi,

This is not a package, it's just a list of different implementations of the NUBAN validation algorithm. If you need to use it in a project, you can copy the code for your language and use it. You can also reference this repo to create a package for the programming language of your choice.

subomi commented 7 years ago

Hey,

Thats the aim for the suggestion, turning it into a package, not just copying it. The advantages are good enough, i guess. And as time goes on more and more projects will need code from here.

Its only a suggestion though, plus the js & python implementations here are still in their infancy.

mojoblanco commented 7 years ago

I understand your point, I don't know all the languages and I can't create all the packages.

I actually have plans on creating at least one package based on this algorithm.

If you can you can also create, would be nice.

subomi commented 7 years ago

Okay, I can create ..

I think whats actually best is to turn all implementations here to a package like in their respective folders. and host them on npm or pypi or any other community packager manager like gem

That way all code still stays here but are all hosted differently for dependencies in our apps.

subomi commented 7 years ago

This way we don't have to create lots of repo for each implementation.