mojoconf / MCT

nothing to see here yet, move along
7 stars 1 forks source link

add a listing of the user's presentations #30

Closed jberger closed 9 years ago

jberger commented 9 years ago

Note that this was not possible when using the routing defined in a94b60c0f43bf0a840066957d8f7d4a1a16684b4 thus I have had to revert it in the best way I understand.

jberger commented 9 years ago

I think the solution to a94b60c0f43bf0a840066957d8f7d4a1a16684b4 is not to nest users under a conference (which we specifically discussed not doing) but rather to define a "current_conference" attribute on the app or some such. It could be detected (we already have that logic) or defined in the configuration (probably best).

Anyway I'm assigning it to you @jhthorsen , please take a look.

jhthorsen commented 9 years ago

I think we need to discuss this further on IRC, but I don't think the initial idea about having "/user/profile" will work. The reason why I think "/user/...." is a bad idea is that it's hard to connect the profile page to the conference you're looking at. I see that you suggest using "current_conference" (fetching the "current" conference from the database). The issue is that I don't think this will work for the next conference:

On the other hand, if we have /:cid/profile the user will still move between the same conference pages. Also, I'm suggesting the profile page has links to the other conferences that is known by the system, so you can move between the pages.

I know, right now this doesn't make much sense, but it's the only thing that makes sense (imo) regarding the data model we decided on, where we have global users and global conferences.

I'm suggesting these routes:

(I think I've covered all the routes now)

jberger commented 9 years ago

First of all, the server is already doing a redirect of / to /<<current_conference>> so I'm not sure what's so hard about having there be an app default of current_conference. If there is a difficulty, it still isn't that hard since they will reach the login page via a specific conference's site, so the act of coming from that site can put a value in the session about which conference they are referring to.

Second, once /:cid is removed from the route, the resulting route GET/POST /user/profile/presentations/:url_name/edit Edit a presentation. will not be sufficient. Presentation url_names are not unique wrt the user and indeed many people give the same talk at multiple conferences.

jberger commented 9 years ago

Personally I don't think there should be a "submit a presentation" action under the user's profile page. As @jhthorsen suggests this is ambiguous, but why is it ambiguous? Because they are unrelated. You should submit a presentation from the conference page.

Links and styling can come either noting the originating site or the server's default conference.

jberger commented 9 years ago

After discussion on IRC, and seeing that ACT does /:cid/user/profile etc I will relent. I'm still not 100% convinced, but it does mean that lots of people disagree with me.

jhthorsen commented 9 years ago

I agree that a talk should be submitted from /:cid/presentations, and has nothing to do with the profile. The main point here is that I want /:cid/ in front of the routes, so don't change conferences or themeing on "random".

I do think /:cid/profile/presentations is a good idea. I'm also fine by replacing "profile" with "user".

jhthorsen commented 9 years ago

What do you think @jberger ?