Presented By: not rendered when viewing abstract

mojoconf / MCT

nothing to see here yet, move along

7 stars 1 forks source link

Presented By: not rendered when viewing abstract #55

Closed rpcme closed 9 years ago

rpcme commented 9 years ago

[04:46:03] riche: batman: I noticed when looking at a submitted abstract, there is a line "Presented by" but it doesn't render the name of the presenter [04:46:45] riche: Profile -> my presentations -> click abstract

render

jhthorsen commented 9 years ago

I think it's because the user doesn't have a name. I guess we could fallback to github username. Will write a unit test to confirm.

I'm also considering making the name/username clickable to a public profile page, where we display:

Name / Github username
Profile picture
Home page url

If you are admin (or logged in as the current user), you will then see the complete profile.

Not sure if there's any issue with that. Do we need a user agreement?

jhthorsen commented 9 years ago

Ah! Opting in by github already allows us to use the public information.

jhthorsen commented 9 years ago

@rpcme: Whenever you submit an issue, please mention the direct url as well. It saves time.