search

mojoconf / MCT

nothing to see here yet, move along
7 stars 1 forks source link

Admin > Purchases, Capture link incorrect for prod #62

Closed rpcme closed 9 years ago

rpcme commented 9 years ago

The Captured link points to test dashboard, not live dashboard. In such case, a 404 is returned.

Please change:

test => ""

meaning:

https://dashboard.stripe.com/test/payments/(token) -> https://dashboard.stripe.com/payments/(token)

jhthorsen commented 9 years ago

This is not the best fix. I think this external_link() method should be moved into the application, so it can create a more dynamic link, dependent on the environment the application is started in.... But, I don't care enough to fix that properly now.

rpcme commented 9 years ago

is it more of a plugin bug then?

jhthorsen commented 9 years ago

"plugin bug" ? The issue is https://github.com/mojoconf/MCT/commit/c649d06f0e55a7013e76ce38ef960d1e17fca046#diff-e15a064597b678f36010375e3cb51501R7

rpcme commented 9 years ago

Oh! I thought maybe you were getting it from a helper in your stripe plugin. My bad!

On Apr 21, 2015, at 3:35 PM, Jan Henning Thorsen notifications@github.com wrote:

"plugin bug" ? The issue is c649d06#diff-e15a064597b678f36010375e3cb51501R7 https://github.com/mojoconf/MCT/commit/c649d06f0e55a7013e76ce38ef960d1e17fca046#diff-e15a064597b678f36010375e3cb51501R7 — Reply to this email directly or view it on GitHub https://github.com/mojoconf/MCT/issues/62#issuecomment-94913951.