Incorrect date type for table users

mojoconf / MCT

nothing to see here yet, move along

7 stars 1 forks source link

Incorrect date type for table users #63

Open rpcme opened 9 years ago

rpcme commented 9 years ago

the datatype is:

timestamp without time zone

this means that you don't want postgres to manage TZ data; fair enough. But there needs to be a single point of reference.

Right now timestamp is being inserted as EST. In such case, this will be very problematic if the database needs to move to another time zone. A single point of reference is required.

Suggestion: use the timestamptz datatype so the date/time is stored internally as UTC.

jhthorsen commented 9 years ago

I'm assigning this to @marcusramberg, because I consider him to be the most capable "DBA" among us. If anyone else feel like taking this, then go crazy.

jhthorsen commented 9 years ago

This type is wrong in all the schemas, and maybe wrong in the code as well. The actual code use logic like INSERT INTO conferences (created, %s) VALUES (CURRENT_TIMESTAMP, %s) RETURNING id. I don't know how CURRENT_TIMESTAMP will behave when the column type is changed.