search

mojohaus / appassembler

https://www.mojohaus.org/appassembler/
MIT License
93 stars 49 forks source link

Fixed #64 - showConsoleWindow=false causes JavaFx window to start min… #113

Closed seanidzenga closed 1 year ago

seanidzenga commented 3 years ago

Same as @leif81

noticed this wasn't fixed today when I went to use the <showConsoleWindow> configuration

seanidzenga commented 3 years ago

@khmarbaise As with Leif's PR there seems to be something misconfigured with Travis CI - if you'd like I can look in to it given the appropriate credentials do so.

khmarbaise commented 3 years ago

This is unrelated to credentials it's simply related to the usage of JDK 7 which is not available anymore on those areas ...apart from general problems on travis-ci https://blog.travis-ci.com/oss-announcement ... it looks like it became time to migrate to something different like Github actions etc.

leif81 commented 3 years ago

@seanidzenga hah great minds.

Same fix as #65

seanidzenga commented 3 years ago

This is unrelated to credentials it's simply related to the usage of JDK 7 which is not available anymore on those areas ...apart from general problems on travis-ci https://blog.travis-ci.com/oss-announcement ... it looks like it became time to migrate to something different like Github actions etc.

Sorry my wording was unclear, I meant "if I were provided the appropriate credentials I could try and fix it"

@khmarbaise Is there a plan to migrate to GitHub actions already in place?

seanidzenga commented 3 years ago

@khmarbaise so what's going on with your Travis CI configuration? what needs to happen to have these PRs accepted?