mojohaus / appassembler

https://www.mojohaus.org/appassembler/
MIT License
93 stars 49 forks source link

General code quality fix-2 #25

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1854 - Dead stores should be removed. squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used instead of Collections.EMPTY_LIST, EMPTY_MAP and EMPTY_SET. squid:S1858 - "toString()" should never be called on a String object. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1596 https://dev.eclipse.org/sonar/rules/show/squid:S1858

Please let me know if you have any questions.

Faisal Hameed