JSW: binaries for 64 bit Windows and other platforms

mojohaus / appassembler

https://www.mojohaus.org/appassembler/

MIT License

93 stars 49 forks source link

JSW: binaries for 64 bit Windows and other platforms #36

Closed zapodot closed 8 years ago

zapodot commented 8 years ago

Hi!

When running the generate-daemons goal with platform specified as jsw the following JSW wrapper executables is added to the bin/ folder of the generated file structure:

AIX-ppc-32 bit
AIX-ppc-64 bit
Linux-x86 32 bit
OSX 32 bit
Solaris-x86 32 bit
Windows-x86 32bit

It would be great to be able to include 64 bit binaries for common platforms such as Windows and Linux. They are made available from JSW central http://wrapper.tanukisoftware.com/doc/english/download.jsp

I haven't found any way of specifying exactly what platforms to target when using the JSW feature. A configurable option would be a great addition to the plugin.

dantran commented 8 years ago

Due to license limitation, this plugin can only contain original 3.2.3. If you want to pick up other 3.2.3, see apache karaf, it has the rest. Otherwise you can deploy higher version to your internal repo, this plugin has option to pick up external JSW bundle

zapodot commented 8 years ago

The 64-bit binaries are indeed included in the sonatype "jsw-binaries" artifact so I was able to include both 32-bit and 64-bit binaries by configuring the plugin with a specific generatorConfiguration:

<daemon>
    <id>daemon</id>
    <mainClass>com.example.Server</mainClass>
    <platforms>
        <platform>jsw</platform>
    </platforms>
    <generatorConfigurations>
        <generatorConfiguration>
            <generator>jsw</generator>
            <includes>
                <include>windows-x86-32</include>
                <include>windows-x86-64</include>
            </includes>
        </generatorConfiguration>
    </generatorConfigurations>
</daemon>

dantran commented 8 years ago

Totally forgot, the plugin also pulls in the ones from sonatype and karaf

https://github.com/mojohaus/appassembler/blob/master/appassembler-maven-plugin/pom.xml

zapodot commented 8 years ago

Maybe the default list of platforms generated as well as how to override it should be documented somewhere?

Anyway: thank you for creating and maintaining a great plugin!

dantran commented 8 years ago

it is documented at http://www.mojohaus.org/appassembler/appassembler-maven-plugin/usage-daemon-platforms.html

I also updated doc to make the available 64bit platforms more obvious