useAllProjectDependencies does not include transitive dependencies

mojohaus / appassembler

https://www.mojohaus.org/appassembler/

MIT License

93 stars 49 forks source link

useAllProjectDependencies does not include transitive dependencies #44

Open jansohn opened 8 years ago

jansohn commented 8 years ago

I want to use the option useAllProjectDependencies=true to also include dependencies in test scope. If I enable this option the transitive dependencies are not copied to the repo directory.

Example

commons-configuration.commons-configuration:1.10 has two transitive dependencies:

commons-lang.commons-lang:2.6
commons-logging.commons-logging:1.1.1

These are only copied if I disable useAllProjectDependencies. Is this behavior as designed or a bug?

I'm using appassembler-maven-plugin 1.10 and JDK 1.8.0_71 (32bit).

NickDiMucci commented 8 years ago

I am also experiencing the same thing. I wouldn't imagine it was by design, seems like a bug, but would like to have that confirmed true or not.

jansohn commented 8 years ago

There's a TODO defined at the relevant location (https://github.com/mojohaus/appassembler/blob/d4cf5f278e95af4f46fa83fcbd3136757935d0ce/appassembler-maven-plugin/src/main/java/org/codehaus/mojo/appassembler/AssembleMojo.java#L261) which seems to indicate that they are aware that the current behavior is not optimal...

EDIT: Actually functionality seems to have changed between Maven 2 and Maven 3 for the method getDependencyArtifacts(). In Maven 3 one should use getArtifacts() instead. (http://stackoverflow.com/q/1492000/3375325)

ncoquelet commented 7 years ago

Hi, any update on this ? I have the same issue. (maven 3.3.9 and appassembler 2.0.0) thanks