search

mojohaus / appassembler

https://www.mojohaus.org/appassembler/
MIT License
93 stars 49 forks source link

EXTRA_JVM_ARGUMENTS wrong documentation #46

Open torakiki opened 8 years ago

torakiki commented 8 years ago

According to the website here, specifying a extraJvmArguments will generate scripts where a an env variable EXTRA_JVM_ARGUMENTS is used to pass the specified args. As far as I understand this is no longer the case since MAPPASM-181.

nezda commented 8 years ago

In those docs, that variable was a local shell script variable set to EXTRA_JVM_ARGUMENTS="" unless configuration.programs.program.jvmSettings.extraArguments.extraArgument were present (then it was set to the space concatenation of those), rather than a way to override generated script setting from the environment though right? Current script generator does seem to not use that approach (just inlines the extraArguments with spaces interposed), but I don't think behavior is different.

In any case, maybe you were attempting to do https://github.com/mojohaus/appassembler/issues/48 too?

torakiki commented 8 years ago

Yes, I guess my use case is similar to #48 , mine is a command line utility and I want to give a simple way to the users to pass/change Xmx and perhaps other jvm args