search

mojohaus / appassembler

https://www.mojohaus.org/appassembler/
MIT License
93 stars 49 forks source link

environmentSetupFileName tag treating value as different #68

Closed maniprabu101993 closed 5 years ago

maniprabu101993 commented 5 years ago

while using this environmentSetupFileName in pom.xml ,values given in the environmentSetupFileName xml tag is not treating the value as same.while creating .bat file it is using the value with suffix .bat and while creating .sh file it is not using the value with suffix .sh.

eg. aaa

In the batch file that is created after building the project ,the value is "if exist "%BASEDIR%\bin\aaa.bat" call "%BASEDIR%\bin\aaa.bat""

In the script file that is created after building the project,the value is [ -f "$BASEDIR"/bin/aaa ] && . "$BASEDIR"/bin/aaa

why it is not suffixing with .sh in the above command.

dantran commented 5 years ago

b/c adding .sh is not necessary on linux, but required on window with .bat. i dont think there is a way to force it to add .sh into unit script

maniprabu101993 commented 5 years ago

[ -f "$BASEDIR"/bin/aaa ] && . "$BASEDIR"/bin/aaa This command is trying to find out the aaa file,but the file system contains aaa.sh .So this condition is failing and the aaa.sh is not executing .

This will make the linux script unusable.Is there any possibility for adding some other tags to replace the contents present in the linux script using maven appassembler?

dantran commented 5 years ago

why can you use just use 'aaa'? b/c of internal build convention?

you can also patch the generated script at build time