mojohaus / appassembler

https://www.mojohaus.org/appassembler/
MIT License
93 stars 49 forks source link

The appassembler-maven-plugin should not store configuration data in global static map #97

Open dhoffer opened 4 years ago

dhoffer commented 4 years ago

The appassembler-maven-plugin should not store binFileExtensions in global static map as it causes the configuration of one module to affect all the other modules in the same build.

We have a large multi-module build where we use the appassembler-maven-plugin in about 30 modules. In all of these we were using the default bin file extension DEFAULT_UNIX_BIN_FILE_EXTENSION for many years. Then yesterday one new module was used where they needed to manually specify the file extension in that one new module.

However because this is loaded into a static map the changes in that one module now effect all the others. This should be changed that all configuration properties are per use of the plugin not globally across all modules.