search

mojohaus / extra-enforcer-rules

Extra Enforcer Rules
https://www.mojohaus.org/extra-enforcer-rules/
Apache License 2.0
73 stars 47 forks source link

failFast needs to be within requireEncoding tag #271

Closed henrik242 closed 7 months ago

henrik242 commented 1 year ago

The documentation shows failFast within the configuration tag:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                </requireEncoding>
              </rules>
              <fastFail>false</fastFail>
            </configuration>

This doesn't work. failFast needs to be with requireEncoding to show all failing files:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                  <fastFail>false</fastFail>
                </requireEncoding>
              </rules>
            </configuration>
slawekjaranowski commented 1 year ago

You right - PR are welcome