Does not handle the `getChildProjectUrlInheritAppendPath` model property

mojohaus / flatten-maven-plugin

Flatten Maven Plugin

https://www.mojohaus.org/flatten-maven-plugin/

Apache License 2.0

204 stars 84 forks source link

Does not handle the `getChildProjectUrlInheritAppendPath` model property #412

Open ppkarwasz opened 5 months ago

ppkarwasz commented 5 months ago

The Maven Flatten Plugin does not handle the [Model#getChildProjectUrlInheritAppendPath](https://maven.apache.org/ref/3.9.0/maven-model/apidocs/org/apache/maven/model/Model.html#getChildProjectUrlInheritAppendPath()) from the original POM and the property is always removed.

Since similar properties in the <scm> element are silently copied, whenever the element is copied, I believe that getChildProjectUrlInheritAppendPath should also always be copied.

jam01 commented 3 months ago

Just ran into this general issue, however I'd suggest SCM drops the attributes instead.

Given my use of the flattened oss pom to give maven central a clean "consumption only" pom, the extra attributes are unnecessary.

In general, to flatten the pom should mean to remove them as well.

ppkarwasz commented 3 months ago

I guess both behaviors should be supported:

if you are flattening a parent POM, these attributes should stay,
if you are flattening a JAR artifact, these attributes are no longer necessary and can be dropped.