Mark javacc-maven-plugin as threadSafe=true

[clebertsuconic]

It appears to me that all is needed is add the definition on the MOJO as From a quick inspection the code seem safe to me.

Is there anything against making it threadSafe=true on the Mojo definition?

[clebertsuconic]

if you build artemis with -TC1:

git clone https://github.com/apache/activemq-artemis.git
cd activemq-artemis
mvn install -TC1 -DskipTests=true

you will see this output:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in ActiveMQ Artemis Selector Implementation:
[WARNING] org.codehaus.mojo:javacc-maven-plugin:3.0.1
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
[

[clebertsuconic]

notice in the above I used 3.0.1, but my pom is currently at an older version now (2.0.something). I was trying 3.0 to see if it made any difference.. and I just inspected the code and this was not changed.

[andrii0lomakin]

Hi guys, is it possible to provide this fix? It will make our builds noticeably faster.

[slawekjaranowski]

We need check if no static instances are used or if is synchronized.

And than Mojo can be mark as threadSafe

[pzygielo]

Is there a chance to have it fixed?