search

mojohaus / jaxb2-maven-plugin

JAXB2 Maven Plugin
https://www.mojohaus.org/jaxb2-maven-plugin/
Apache License 2.0
105 stars 76 forks source link

Support for JAXB 3 #175

Closed adamretter closed 3 years ago

adamretter commented 3 years ago

This finishes the work that was started by @rlfnb in https://github.com/mojohaus/jaxb2-maven-plugin/pull/166 to update the plugin for JAXB 3, so that all tests and integration tests now pass. Dependencies have also been bought up to date.

It does strike me however that the plugin is named jaxb2-maven-plugin and so perhaps we might want to fork this to jaxb3-maven-plugin rather than just merging the PR to this repository?

Thoughts?

Closes https://github.com/mojohaus/jaxb2-maven-plugin/issues/165 Closes https://github.com/mojohaus/jaxb2-maven-plugin/pull/166

dizzzz commented 3 years ago

This is a must-have i'd say

Chavjoh commented 3 years ago

Can someone merge this PR ? I didn't find any other maven plugin alternative for JAXB 3.0.0, it would be really useful for a lot of people, I think, to have this release.

dantran commented 3 years ago

@adamretter I will merge it. However, push snapshot to oss.sonartype is problematic these days. Thanks

adamretter commented 3 years ago

Thanks @dantran. Will it be possible to get a release out too?

dantran commented 3 years ago

@adamretter

I am running into a dilemma, it seems I need to use the latest mojo-parent(60) in order to deploy and release, however, doing so breaks maven site

At the same time, windows build has one unit test failure

jaxb3 support fully backward compatible with jaxb2?

dantran commented 3 years ago

@adamretter I am able to fix the maven site issue

dantran commented 3 years ago

@adamretter jaxb3 support fully backward compatible with jaxb2?

adamretter commented 3 years ago

@dantran What is the issue that you are seeing? If you can point me to it and tell me how to reproduce, then I might have some ideas

adamretter commented 3 years ago

@dantran I found a single failing test on Windows which is FileSystemUtilitiesTest#validateRelativizingPaths(). However, having done some investigation it appears that this test was failing even before my PR.

@dantran I just sent a PR to fix the Windows failing test - https://github.com/mojohaus/jaxb2-maven-plugin/pull/178 Is there anything further I can do to assist in getting a release of this out?

adamretter commented 3 years ago

I am afraid that we really needed a release and so I forked the project to https://github.com/evolvedbinary/mojohaus-jaxb-maven-plugin and added the Windows fix https://github.com/mojohaus/jaxb2-maven-plugin/pull/178 and released it here - https://search.maven.org/search?q=com.evolvedbinary.maven.mojohaus

I am hoping it is a short-lived fork and we can replace it with an updated "official" MojoHaus release when that is ready.

cristiammercado commented 3 years ago

@adamretter Thank you much! I was waiting for a long time to this release and nothing happened!

adamretter commented 3 years ago

@cristiammercado thanks and you are welcome

dantran commented 3 years ago

@adamretter I staged 3.0.0 and called our a vote at https://groups.google.com/g/mojohaus-dev/c/1Sdm-4PKjLs

please help testing the staged artifact. and add your vote there

Thanks for works on jaxb 3.0 support.

adamretter commented 3 years ago

Thanks @dantran I will take a look and see what I can do.

adamretter commented 3 years ago

@dantran It says I don't have permissions to contribute to that Google Group, and I can't find a sign-up link. Any ideas?

dantran commented 3 years ago

do you see this ? https://groups.google.com/g/mojohaus-dev

adamretter commented 3 years ago

@dantran got it, thanks!